Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve settings and properties #577

Merged
merged 25 commits into from
Jan 10, 2025
Merged

Improve settings and properties #577

merged 25 commits into from
Jan 10, 2025

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented Jan 10, 2025

  • Fix xp rate modifier property
  • Fix music unlock command
  • Add Settings class to handle all properties
  • Add settings reload command
  • Add settings reload event
  • Migrate all koin properties to use Settings
  • Fix incorrect inject() usages
  • Add shooting star command
  • Add shooting star respawn time to settings
  • Add shooting star global message
  • Add setting for global messages
  • Refactor game.properties to use hierarchy
  • Format and organise game.properties
  • Add setting for essence pouch degrading
  • Add setting for infinite run
  • Add setting for bot random walking
  • Add setting for disabling npc aggressiveness in lumbridge
  • Add setting for dummy networked bots
  • Add settings for new account setup options

GregHib added 24 commits January 9, 2025 14:44
@GregHib
Fix xp rate modifier
ff27339
@GregHib
Fix music unlock command
fa411d6
@GregHib
Fix tests for experience rate
7487c61
@GregHib
Add Settings closes #576
968599d
@GregHib
Add settings reload event
50fd017
@GregHib
Convert properties to load via Settings
d64b63d
@GregHib
Fix incorrect inject() usages
fbef3d1
@GregHib
Convert properties to Settings
7e4486f
@GregHib
Fix left-over state effecting other tests
549843d
@GregHib
Convert World variables to Settings
039dcf5
@GregHib
Convert missed property loading
c456a91
@GregHib
Refactor game.properties
cf037ff
@GregHib
Add shooting star respawn time settings and command
1062675
@GregHib
Add global event message
e5e2505
@GregHib
Add toggle for esse pouch degrading
fda9a6b
@GregHib
Add infinite run energy toggle
91369a7
@GregHib
Add bots random walk setting
5681831
@GregHib
Add networked bots as dev setting
bf56bcc
@GregHib
Add lumbridge safe zone setting
69e8d54
@GregHib
More refactoring
967002c
@GregHib
More organising and add a few startup configs
8bb82f6
@GregHib
Make home tile and exp rate settings dynamic
84585c5
@GregHib
Replace Main.name with server.name setting
cb73da6
@GregHib
Fix network test
a2a7e26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@GregHib GregHib merged commit 30c01ae into main Jan 10, 2025
3 checks passed
@GregHib GregHib deleted the settings-improvements branch January 10, 2025 17:52
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 29.24901% with 179 lines in your changes missing coverage. Please review.

Project coverage is 34.62%. Comparing base (c4c2bb6) to head (64641f1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/world/activity/dnd/shootingstar/ShootingStar.kts 0.00% 24 Missing and 1 partial ⚠️
.../kotlin/world/gregs/voidps/engine/EngineModules.kt 0.00% 17 Missing ⚠️
...c/main/kotlin/world/gregs/voidps/bot/BotSpawns.kts 0.00% 15 Missing and 1 partial ⚠️
game/src/main/kotlin/world/gregs/voidps/Main.kt 0.00% 13 Missing ⚠️
...ld/gregs/voidps/world/interact/entity/Movement.kts 38.88% 0 Missing and 11 partials ⚠️
.../kotlin/world/gregs/voidps/engine/data/Settings.kt 56.52% 8 Missing and 2 partials ⚠️
...s/voidps/world/interact/world/map/Introduction.kts 18.18% 8 Missing and 1 partial ⚠️
...n/world/gregs/voidps/engine/data/SettingsReload.kt 0.00% 8 Missing ⚠️
.../main/kotlin/world/gregs/voidps/bot/TaskManager.kt 44.44% 5 Missing ⚠️
...gregs/voidps/world/command/admin/AdminCommands.kts 0.00% 4 Missing ⚠️
... and 49 more
Additional details and impacted files
Files with missing lines Coverage Δ
.../src/main/kotlin/world/gregs/voidps/engine/Koin.kt 0.00% <ø> (ø)
...n/world/gregs/voidps/engine/data/AccountManager.kt 75.94% <100.00%> (ø)
...otlin/world/gregs/voidps/engine/data/PlayerSave.kt 56.33% <100.00%> (ø)
...world/gregs/voidps/engine/data/json/FileStorage.kt 100.00% <100.00%> (ø)
...ld/gregs/voidps/engine/data/sql/DatabaseStorage.kt 98.62% <100.00%> (-0.01%) ⬇️
.../voidps/engine/data/yaml/PlayerYamlReaderConfig.kt 96.87% <100.00%> (-0.27%) ⬇️
...d/gregs/voidps/engine/entity/character/npc/NPCs.kt 0.00% <ø> (ø)
...gregs/voidps/engine/entity/item/drop/DropTables.kt 81.48% <100.00%> (ø)
...egs/voidps/bot/navigation/graph/NavigationGraph.kt 77.77% <100.00%> (ø)
...n/kotlin/world/gregs/voidps/script/ScriptLoader.kt 85.18% <100.00%> (ø)
... and 78 more

... and 5 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #577      +/-   ##
============================================
+ Coverage     34.57%   34.62%   +0.05%     
  Complexity     4846     4846              
============================================
  Files          1342     1344       +2     
  Lines         47044    47073      +29     
  Branches       9509     9527      +18     
============================================
+ Hits          16264    16298      +34     
+ Misses        27388    27373      -15     
- Partials       3392     3402      +10
Components Coverage Δ
Content 28.29% <28.27%> (-0.06%) ⬇️
Engine 43.22% <24.46%> (+0.06%) ⬆️
Network 71.92% <100.00%> (+1.23%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GregHib